QRCode bug

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

QRCode bug

thedivrox
Hi Folks,
           I am using the excellent QRCode plugin (author Shawn Hartsock).
However, I believe I found a bug in the plugin.
 
Inside QRCodeController, it seems the wrong param is getting used:

  def text = {
    // Old version, actual param should be "t", not "text"
    // String content = params.text
    String content = params.t // corrected version
    String size = getSize(params)
    qrcodeRenderer.renderPng(response, content, size.toInteger().intValue())
  }

The "qrcode:image text=" tag works lots better now!

Please forgive me if I am breaking some forum protocol here, but protocol was never a strength :-)

Thanks,
Mark
Reply | Threaded
Open this post in threaded view
|

Re: QRCode bug

pledbrook
Administrator
> Inside QRCodeController, it seems the wrong param is getting used:
>
>   def text = {
>     // Old version, actual param should be "t", not "text"
>     // String content = params.text
>     String content = params.t // corrected version
>     String size = getSize(params)
>     qrcodeRenderer.renderPng(response, content, size.toInteger().intValue())
>   }
>
> The "qrcode:image text=" tag works lots better now!

I would raise an issue at http://jira.grails.org/browse/GRAILSPLUGINS
and attach a patch. Post the URL of the issue here and I'll assign it
to Shawn.

--
Peter Ledbrook
Grails Advocate
SpringSource - A Division of VMware